[BoundsSafety] Rename experimental C++ and Objective-C flags and make them CC1 only #10635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delcypher
requested review from
hnrklssn,
rapidsna,
patrykstefanski and
apple-fcloutier
delcypher
added
the
clang:bounds-safety
|
@swift-ci test llvm |
delcypher
commented
May 7, 2025
| @@ -543,8 +543,8 @@ BENIGN_LANGOPT(CheckConstexprFunctionBodies, 1, 1, | |||
| LANGOPT(BoundsSafety, 1, 0, "Bounds safety extension for C") | |||
| /* TO_UPSTREAM(BoundsSafety) ON*/ | |||
| LANGOPT(BoundsSafetyAttributes, 1, 0, "Experimental bounds safety attributes") | |||
| LANGOPT(BoundsAttributesCXXExperimental, 1, 0, "Experimental bounds attributes for C++") | |||
| LANGOPT(BoundsAttributesObjCExperimental, 1, 0, "Experimental bounds attributes for Objective-C") | |||
| LANGOPT(BoundsSafetyCXXExperimental, 1, 0, "Experimental bounds attributes for C++") | |||
There was a problem hiding this comment.
@hnrklssn @patrykstefanski @rapidsna Should we drop the Experimental suffix from the language option? Upstream doesn't seem to do this but I kind of like having the suffix there because it makes it much clearer that this language option is experimental.
There was a problem hiding this comment.
I have no strong opinion in either direction on this one
hnrklssn
approved these changes
May 7, 2025
… them CC1 only The existing `-fbounds-attributes-cxx-experimental` and `-fbounds-attributes-objc-experimental` flags were previously exposed as driver and CC1 flags. However, given that these modes are highly experimental we don't want to encourage their use so these flags have no been made CC1 only flags. The functionality is still available from the driver by doing `-Xclang <flag name>`. This patch also does a rename of the flags to be prefixed with `experimental-` which upstream prefers. 1. `-fbounds-attributes-cxx-experimental` -> `-fexperimental-bounds-safety-cxx` 2. `-fbounds-attributes-objc-experimental` -> `-fexperimental-bounds-safety-objc`. This patch also renames "bounds attributes" to "bounds safety" for things associated with these flags (e.g. `LangOptions::BoundsSafetyCXXExperimental`). "bounds attributes" is the legacy name that we need to slowly purge from the codebase and this is one small step towards that goal. rdar://149423268
delcypher
force-pushed
the
dliew/rdar-149423268
branch
from
b30b975 to
89573e8
Compare
|
@swift-ci test llvm |
|
Compile errors look unrelated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
-fbounds-attributes-cxx-experimentaland-fbounds-attributes-objc-experimentalflags were previously exposed as driver and CC1 flags. However, given that these modes are highly experimental we don't want to encourage their use so these flags have no been made CC1 only flags. The functionality is still available from the driver by doing-Xclang <flag name>.This patch also does a rename of the flags to be prefixed with
experimental-which upstream prefers.-fbounds-attributes-cxx-experimental->-fexperimental-bounds-safety-cxx-fbounds-attributes-objc-experimental->-fexperimental-bounds-safety-objc.This patch also renames "bounds attributes" to "bounds safety" for things associated with these flags (e.g.
LangOptions::BoundsSafetyCXXExperimental). "bounds attributes" is the legacy name that we need to slowly purge from the codebase and this is one small step towards that goal.rdar://149423268