Skip to content

[6.2][CAS] sync memory mapped file when closing CAS #10634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

[6.2][CAS] sync memory mapped file when closing CAS #10634

merged 1 commit into from
May 9, 2025
+14 −1

Conversation

cachemeifyoucan
Copy link

  • Explanation: To avoid unnecessary data lost due to power lost immediately after the build, make sure the mapped files in the CAS are sync'ed back to the file system when the last user of the CAS closed the file.
  • Scope: For better caching usage and unexpected data lost.
  • Issues: rdar://150379440
  • Original PRs: [CAS] sync memory mapped file when closing CAS #10625
  • Risk: Low. Caching build only.
  • Testing: Local Performance benchmark.
  • Reviewers: @akyrtzi
@cachemeifyoucan
[CAS] sync memory mapped file when closing CAS
bbc8589 
To avoid unnecessary data lost due to power lost immediately after the
build, make sure the mapped files in the CAS are sync'ed back to the
file system when the last user of the CAS closed the file.

rdar://150379440
(cherry picked from commit a67d9ef)
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner May 7, 2025 18:11
@cachemeifyoucan
Copy link
Author

@swift-ci please test
@cachemeifyoucan cachemeifyoucan changed the title [CAS] sync memory mapped file when closing CAS May 8, 2025
@fredriss fredriss merged commit b0d6e64 into swiftlang:swift/release/6.2 May 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@cachemeifyoucan @akyrtzi @fredriss