[BoundsSafety] Fix update_cc_test_checks.py to correctly regenerate CodeGen tests
#10627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CodeGen tests When rdar://148623233 (swiftlang#10619) landed the BoundsSafety test directories now have compiler flags implicitly passed when using the `%clang_cc1` substitution. This is done using the `lit.local.cfg.py` files under `clang/test/BoundsSafety` and `clang/test/BoundsSafety-legacy-checks`. However, the `update_cc_test_checks.py` script doesn't know anything about the `llvm-lit` configuration. Instead, it hardcodes what `%clang_cc1` expands to. This can cause problems when using the script because the script invokes clang differently to how `llvm-lit` will do it. To avoid these problems the following changes are made * Tests under `clang/test/BoundsSafety` have `-fbounds-safety-bringup-missing-checks=batch_0` implicitly passed * Tests under `clang/test/BoundsSafety-legacy-checks` have `-fno-bounds-safety-bringup-missing-checks=all` passed We can remove this entirely once support for the legacy bounds safety checks are removed. rdar://150800853
delcypher
added
the
clang:bounds-safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rdar://148623233 (#10619) landed the BoundsSafety test directories now have compiler flags implicitly passed when using the
%clang_cc1substitution. This is done using thelit.local.cfg.pyfiles underclang/test/BoundsSafetyandclang/test/BoundsSafety-legacy-checks.However, the
update_cc_test_checks.pyscript doesn't know anything about thellvm-litconfiguration. Instead, it hardcodes what%clang_cc1expands to. This can cause problems when using the script because the script invokes clang differently to howllvm-litwill do it.To avoid these problems the following changes are made
clang/test/BoundsSafetyhave-fbounds-safety-bringup-missing-checks=batch_0implicitly passedclang/test/BoundsSafety-legacy-checkshave-fno-bounds-safety-bringup-missing-checks=allpassedWe can remove this entirely once support for the legacy bounds safety checks are removed.
rdar://150800853