Skip to content

[clang][deps][cas] CAS test for llvm#138920 #10624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

jansvoboda11
Copy link

@jansvoboda11 jansvoboda11 commented May 6, 2025

In addition to the dependency issue described in llvm#138920, not rebuilding an implicit module when its explicitly-built dependency got out of date made us use stale include-tree of the implicitly-built module, which caused file content conflicts and the "file changed during build" error message.

rdar://150230022

@jansvoboda11
Copy link
Author

@swift-ci please test

In addition to the dependency issue described in llvm#138920, not rebuilding an implicit module when its explicitly-built dependency got out of date made us use stale include-tree of the implicitly-built module, which caused file content conflicts and the "file changed during build" error message.

rdar://150230022
@jansvoboda11 jansvoboda11 force-pushed the jan_svoboda/cas-pch-stale-pcm branch from 48f986f to bff95d0 Compare May 8, 2025 14:43
@jansvoboda11 jansvoboda11 changed the title [clang][deps][cas] Avoid referring to stale explicitly-built PCMs May 8, 2025
@jansvoboda11
Copy link
Author

@swift-ci please test

Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansvoboda11 jansvoboda11 merged commit 16c5c0b into next May 9, 2025
0 of 3 checks passed
@jansvoboda11 jansvoboda11 deleted the jan_svoboda/cas-pch-stale-pcm branch May 9, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants