Skip to content

[next] Cherry-pick Swift-specific LLDB adjustments #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 5, 2025
Merged

[next] Cherry-pick Swift-specific LLDB adjustments #10618

merged 17 commits into from
May 5, 2025

Conversation

bnbarham
Copy link

@bnbarham bnbarham commented May 3, 2025

No description provided.

adrian-prantl and others added 17 commits May 2, 2025 17:08
@adrian-prantl @bnbarham
[stable/20250402] Cherry-pick "[lldb] Upgrade CompilerType::GetBitSiz…
18227a6 
…e to return llvm::Expected (llvm#129601)"

This patch pushes the error handling boundary for the GetBitSize()
methods from Runtime into the Type and CompilerType APIs. This makes
it easier to diagnose problems thanks to more meaningful error
messages being available. GetBitSize() is often the first thing LLDB
asks about a type, so this method is particularly important for a
better user experience.

rdar://145667239
(cherry picked from commit 878a64f)

(cherry picked from commit 642dcd7)
(cherry picked from commit d3e7a33)
@AnthonyLatsis @bnbarham
[LLDB] Fix faulty merge
b250056 
We lost a conditionally used variable in
15070b3.

(cherry picked from commit 3b5119d)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Fix faulty cherry-pick
dd2b5a4 
We accidentally redefined a function in
305e024.

(cherry picked from commit 8670119)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust use of llvm::Module::setTargetTriple (paramete…
9d4915e 
…r type changed)

Per 979c275 (llvm-project).

(cherry picked from commit 1631026)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Refactor method override (parameter type changed)
5e9fb22 
Per 2a3c08f. Also see
57b4898.

(cherry picked from commit 6add869)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust method override (parameter type changed)
425218e 
Per 28050e1.

(cherry picked from commit adc1439)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust method override (parameter type changed)
813e73f 
Per ddf40e0.

(cherry picked from commit 4b679f0)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Switch from UnwindPlan::RowSP to UnwindPlan::Row
12b19a4 
Per d7cea2b. See also:
b3b5527.

(cherry picked from commit 273c1ad)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust call to TypeSystemClang::GetMetadata (return t…
a5fa504 
…ype changed)

Per f9f0ae1.

(cherry picked from commit 154efe7)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Add missing TypeSummaryImpl::GetName implementations
68e65f8 
Per 22144e2.

(cherry picked from commit 218e173)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust includes of moved Clang headers
c30cc8f 
Per 0d150db.

(cherry picked from commit 0ce4444)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust calls to moved & renamed methods
59d6a25 
Per 460c0f5.

(cherry picked from commit 826c36e)
@AnthonyLatsis @bnbarham
[LLDB] Swift: s/DWARFRangeList/llvm::DWARFAddressRangeVector
e8f5534 
Per fb8df8c.

(cherry picked from commit 8a94a74)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Adjust call to Function::GetStartLineSourceInfo (para…
c9f9633 
…meter type changed)

Per 39b2979.

(cherry picked from commit 1a10d6b)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Refactor call to now protected method
5c9b85d 
Per c4fb718.

(cherry picked from commit 26e0ab5)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Add missing argument to call
8b90bf4 
Per 246c240.

(cherry picked from commit 4bcd0b3)
@AnthonyLatsis @bnbarham
[LLDB] Swift: Refactor TypeSystemSwiftTypeRef after `CompilerContex…
4bf37fd 
…tKind::AnyModule` removal

Per 212950f.

(cherry picked from commit 0b6504a)
@bnbarham bnbarham requested a review from JDevlieghere as a code owner May 3, 2025 00:11
@bnbarham bnbarham merged commit c7c3003 into swiftlang:next May 5, 2025
@bnbarham bnbarham deleted the cherry-missing-lldb branch May 5, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@bnbarham @adrian-prantl @AnthonyLatsis