Skip to content

🍒[lldb][Format] Add function.suffix frame-format variable #10579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

Michael137
Copy link

@Michael137 Michael137 commented Apr 29, 2025

This patch adds another frame-format variable (currently only implemented in the CPlusPlus language plugin) that represents the "suffix" of a function. The name is derived from the DotSuffix node of LLVM's Itanium demangler.

For a function name such as int foo() (.cold), the suffix would be (.cold).

(cherry picked from commit 64b5bc8)

rdar://150174227

This patch adds another frame-format variable (currently only
implemented in the CPlusPlus language plugin) that represents the
"suffix" of a function. The name is derived from the `DotSuffix` node of
LLVM's Itanium demangler.

For a function name such as `int foo() (.cold)`, the suffix would be
`(.cold)`.

(cherry picked from commit 64b5bc8)
@Michael137 Michael137 requested a review from a team as a code owner April 29, 2025 10:50
@Michael137
Copy link
Author

@swift-ci test

We skip/xfail the other FrameFormat tests on Windows already. The number
of different buildbot configurations out there targetting Windows makes
it hard to make this test portable. If we want to test this on Windows
we should probably just make a dedicated test for it.

(cherry picked from commit 4560ff8)
@Michael137
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit 5842d95 into swift/release/6.2 Apr 30, 2025
3 checks passed
@adrian-prantl adrian-prantl deleted the lldb/suffix-frame-format-to-6.2 branch April 30, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants