Skip to content

add a test for issue rust-lang/rust#81317 #140632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

add a test for issue rust-lang/rust#81317 #140632

merged 3 commits into from
May 6, 2025

Conversation

Skgland
Copy link
Contributor

@Skgland Skgland commented May 3, 2025

closes #81317
@rustbot
Copy link
Collaborator

rustbot commented May 3, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2025
@jieyouxu
Copy link
Member

jieyouxu commented May 4, 2025 •
edited
Loading

I'm slightly confused -- is this a regression test, or does it just try to make sure even further changes to this code pattern is observed in PR test diffs? (Because the MCVE still doesn't compile, since 1.49, due to inference changes.) Would be good clarifying that in the test comment.
r? @oli-obk
@rustbot rustbot assigned oli-obk and unassigned jieyouxu May 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented May 6, 2025

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented May 6, 2025

📌 Commit fb87845 has been approved by oli-obk

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 6, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2025
@bors
Auto merge of rust-lang#140702 - GuillaumeGomez:rollup-rpyxs20, r=Gui…
1a95cc6 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#140135 (Unify sidebar buttons to use the same image)
 - rust-lang#140632 (add a test for issue rust-lang#81317)
 - rust-lang#140658 (`deref_patterns`: let string and byte string literal patterns peel references and smart pointers before matching)
 - rust-lang#140681 (Don't ignore compiler stderr in `lib-defaults.rs`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3501842 into rust-lang:master May 6, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 6, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2025
@rust-timer
Unrolled build for rust-lang#140632
451cc1b 
Rollup merge of rust-lang#140632 - Skgland:test-for-issue-81317, r=oli-obk

add a test for issue rust-lang#81317

closes rust-lang#81317
@Skgland Skgland deleted the test-for-issue-81317 branch May 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
6 participants
@Skgland @rustbot @jieyouxu @rust-log-analyzer @oli-obk @bors