gh-132983: Fix small issues with zstd support in zipfile #133723
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatyping
reviewed
May 9, 2025
There was a problem hiding this comment.
Thanks, these changes look good! I had a few minor suggestions. I think we should be careful how we document the accepted values for zstd's compression level. I don't think we can or should hardcode the values, but I also think giving a pointer to where the current values can be found would be useful.
11 tasks
Co-authored-by: Emma Smith <emma@emmatyping.dev>
AA-Turner
reviewed
May 9, 2025
|
All requested changes applied. I see a test failed, but as far as I can tell it's not related to the changes in this PR. |
AA-Turner
approved these changes
May 10, 2025
emmatyping
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small tweaks to the zipfile zstd support added in #133365
ZIP_ZSTANDARDconstant to the module's__all__ZipFile's docstring.min_levelin_write_end_recordcompresslevelinto theZstdCompressorand document it.Note: I didn't create an issue because this all seems fairly trivial, but I can if needed.
CC: @emmatyping @gpshead