Skip to content

gh-133532: Run GC fast cycles test in subprocess. #133533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2025
Merged

gh-133532: Run GC fast cycles test in subprocess. #133533

merged 5 commits into from
May 8, 2025
+54 −56

Conversation

nascheme
Copy link
Member

@nascheme nascheme commented May 6, 2025 •
edited by bedevere-app bot
Loading

This makes the test more reliable since there are not extra objects on the heap leftover from other tests.
@bedevere-app bedevere-app bot mentioned this pull request May 6, 2025
Open
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 6, 2025
@nascheme nascheme requested a review from markshannon May 6, 2025 19:28
@nascheme nascheme marked this pull request as ready for review May 6, 2025 21:03
@AA-Turner AA-Turner mentioned this pull request May 7, 2025
Closed
markshannon
markshannon approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe we could reduce the 27k limit, but I don't know if it is worth messing with here.
@nascheme nascheme enabled auto-merge (squash) May 7, 2025 16:58
@nascheme nascheme merged commit 8598e57 into python:main May 8, 2025
38 checks passed
@nascheme nascheme added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@miss-islington-app
Copy link

Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2025
@nascheme @miss-islington
pythongh-133532: Run GC fast cycles test in subprocess. (pythongh-133533
74f77f7 
)

This makes the test more reliable since there are not extra objects on the heap leftover
from other tests.
(cherry picked from commit 8598e57)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

GH-133716 is a backport of this pull request to the 3.14 branch.
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025
nascheme added a commit that referenced this pull request May 9, 2025
@miss-islington @nascheme
[3.14] gh-133532: Run GC fast cycles test in subprocess. (gh-133533) (g…
aaeca91 
…h-133716)

This makes the test more reliable since there are not extra objects on the heap leftover
from other tests.

(cherry picked from commit 8598e57)

Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
4 participants
@nascheme @markshannon @chris-eibl @AA-Turner