Add pg_upgrade option #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonolock
force-pushed
the
update_node_func
branch
5 times, most recently
from
17fb333 to
2654ee1
Compare
asavchkov
reviewed
Dec 21, 2023
| @@ -127,20 +127,23 @@ def __repr__(self): | |||
|
|
|||
|
|
|||
| class PostgresNode(object): | |||
| def __init__(self, name=None, port=None, base_dir=None, conn_params: ConnectionParams = ConnectionParams()): | |||
| def __init__(self, name=None, port=None, base_dir=None, conn_params: ConnectionParams = ConnectionParams(), bin_dir=None, prefix=None): | |||
There was a problem hiding this comment.
Do you really need to change anything with respect to prefix? It only determines the path to the temporary folders used for running tests. Tests are run with the new node only, not with the old one, so the old node should not need temporary folders (and thus its own prefix) at all.
There was a problem hiding this comment.
Prefix is used as parameter for this structure
self._base_dir = self.os_ops.mkdtemp(prefix=self._prefix or TMP_NODE)
TMP_NODE - is just generated string that hard to read and memorize. Adding the parameter will make tests easer for reading and understanding.
demonolock
force-pushed
the
update_node_func
branch
3 times, most recently
from
248ced6 to
334bb22
Compare
demonolock
force-pushed
the
update_node_func
branch
from
334bb22 to
15e3fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.