Fix error 'Is another postmaster already running on port XXX' #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonolock
reviewed
Apr 5, 2024
| raise Exception | ||
| elif out and 'Is another postmaster already running on port' in out and startup_retries > 0: | ||
| self.port = reserve_port() | ||
| options['port'] = str(self.port) |
There was a problem hiding this comment.
flake8 упал
- flake8 .
./build/lib/testgres/node.py:737:21: F821 undefined name 'options'
./build/lib/testgres/node.py:738:40: F821 undefined name 'options'
./testgres/node.py:737:21: F821 undefined name 'options'
./testgres/node.py:738:40: F821 undefined name 'options'
There was a problem hiding this comment.
Переделала, тесты прошли
MetalDream666
force-pushed
the
fix-already-used-port-startup-error
branch
6 times, most recently
from
6f57364 to
8a5e75f
Compare
demonolock
approved these changes
Apr 5, 2024
MetalDream666
force-pushed
the
fix-already-used-port-startup-error
branch
2 times, most recently
from
242e01f to
63e2061
Compare
Sometimes when we abnormally shutdown node its port stays busy. So I added retry attempts to start() function in case we encounter such error. Test for this case was added (test_the_same_port).
MetalDream666
force-pushed
the
fix-already-used-port-startup-error
branch
from
63e2061 to
fba3bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when we abnormally shutdown node its port stays busy. So I added retry attempts to start() function in case we encounter such error