Skip to content

Adding port and database name into params list for add-instance command #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2024
Merged

Adding port and database name into params list for add-instance command #118

merged 1 commit into from
Apr 4, 2024

Conversation

egarbuz
Copy link
Collaborator

@egarbuz egarbuz commented Apr 3, 2024

No description provided.

demonolock
demonolock reviewed Apr 3, 2024
View reviewed changes
testgres/plugins/pg_probackup2/pg_probackup2/app.py
@@ -149,13 +149,19 @@ def init(self, options=None, old_binary=False, skip_log_directory=False, expect_
use_backup_dir=use_backup_dir
)

def add_instance(self, instance, node, old_binary=False, options=None, expect_error=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use datname=None as unset value
@demonolock demonolock merged commit 4c70b80 into master Apr 4, 2024
2 checks passed
@demonolock demonolock deleted the Adding_port_and_database_params_to_add_instance branch April 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@egarbuz @demonolock