2to3: Apply nonzero fixer. #3241
Conversation
In Python 3 the `__nonzero__` class method is replaced by `__bool__`. This only affects the MaskedArray class in numpy/oldnumeric/ma.py file and the simplest solution is to provide both methods. I have my doubts that the fixed up Python 3 version was correct or even tested, but I think the current solution should work for as long as oldnumeric stays in numpy. Closes numpy#3073.
|
Still looks good in the morning. This is a minimal change that adds a method expected by Python 3. 2to3 would just rename the nonzero method, so the copy here should have the same result. |
|
Better than copy/pasting the code would be to call nonzero or just write bool = nonzero Not a big deal though.
|
|
Heh, yeah. I did consider it, but copy paste was less work ;) Plus if we ever drop 2.7, say in ten years of so, and this module is still around, we can erase nonzero. |
|
Sure. And I guess it's not too likely they'll diverge given that no-one On Sun, Apr 14, 2013 at 10:42 PM, Charles Harris
|
In Python 3 the
__nonzero__class method is replaced by__bool__.This only affects the MaskedArray class in numpy/oldnumeric/ma.py file
and the simplest solution is to provide both methods. I have my doubts
that the fixed up Python 3 version was correct or even tested, but I
think the current solution should work for as long as oldnumeric stays
in numpy.
Closes #3073.