-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(zigbee): Add support for Binary input EP + Analog EP extension #11339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(zigbee): Add support for Binary input EP + Analog EP extension #11339
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 44s ⏱️ Results for commit 6392dd3. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the Zigbee library by adding a new Zigbee Binary Endpoint and enhancing the Analog Endpoint with mandatory attributes needed by ZHA. Key changes include the implementation of binary input support, the addition of application type, description, and resolution attributes for analog clusters, and corresponding updates to examples and documentation.
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
libraries/Zigbee/src/ep/ZigbeeBinary.h | Introduces the Binary Endpoint header (note: update internal comment to correctly refer to a binary sensor). |
libraries/Zigbee/src/ep/ZigbeeBinary.cpp | Implements binary cluster functions; error message text inconsistency observed in setBinaryInputApplication. |
libraries/Zigbee/src/ep/ZigbeeAnalog.h | Adds new API prototypes for setting analog application type, description, and resolution. |
libraries/Zigbee/src/ep/ZigbeeAnalog.cpp | Updates Analog Endpoint functionality by adding extra mandatory attributes and cluster handling. |
libraries/Zigbee/src/Zigbee.h | Updates include list to add the new Zigbee Binary Endpoint. |
libraries/Zigbee/examples/Zigbee_Binary_Input/*.ino and README.md | Demonstrates usage of the new binary endpoint. |
libraries/Zigbee/examples/Zigbee_Analog_Input_Output/*.ino | Shows extended analog input/output examples with new attribute settings. |
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- libraries/Zigbee/examples/Zigbee_Binary_Input/ci.json: Language not supported
libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description of Change
This PR adds support for Zigbee Binary Input EP + example.
Also adds
description
andapplication_type
attributes for Analog EP class. Those 2 new attributes are mandatory for ZHA for the device to be shown correctly.Tests scenarios
Tested using included examples and HA with a ZHA dev branch as the AnalogInput+BinaryInput changes are pending for the 2025.5.0 version or later.
Related links