-
Notifications
You must be signed in to change notification settings - Fork 2k
move cli/internal/ packages to top-level internal/ #6054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6054 +/- ##
=======================================
Coverage 58.99% 58.99%
=======================================
Files 358 358
Lines 30004 30004
=======================================
Hits 17700 17700
Misses 11323 11323
Partials 981 981 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates multiple internal packages by moving them from a nested cli/internal/ location to a single top-level internal/ package.
- Updated import paths for jsonstream and oauth/manager (among others) in various CLI commands.
- Simplified package structure by collapsing redundant internal package hierarchies.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
cli/trust/trust_push.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/swarm/ca.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/service/logs.go | Updated the logdetails import to the new top-level internal path. |
cli/command/service/helpers.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/registry/logout.go | Updated the oauth/manager import to the new top-level internal path. |
cli/command/registry/login.go | Updated the oauth/manager import to the new top-level internal path. |
cli/command/plugin/upgrade.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/plugin/push.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/plugin/install.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/image/trust.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/image/push.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/image/load.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/image/import.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/image/build.go | Updated the jsonstream import to the new top-level internal path. |
cli/command/container/create.go | Updated the jsonstream import to the new top-level internal path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thx! I was going back and forth a bit "should we keep separation?" but I think the current decision "which internal one?" was blurry enough to consider; let's just use a single one, until we have a strong reason to split ❤️ |
We were using 2 separate
internal/
packages; while it could make sense to scope these packages to a specific sub-package, our currently distinction between the top-levelinternal/
andcli/internal/
was a bit blurry.Let's simplify for now, and use a single, top-level
internal/
package. We can always change this in future if there's a need.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)