Skip to content

move cli/internal/ packages to top-level internal/ #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

We were using 2 separate internal/ packages; while it could make sense to scope these packages to a specific sub-package, our currently distinction between the top-level internal/ and cli/internal/ was a bit blurry.

Let's simplify for now, and use a single, top-level internal/ package. We can always change this in future if there's a need.

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah added 3 commits May 6, 2025 20:04
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 28.1.2 milestone May 6, 2025
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels May 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (25a1681) to head (479c7ad).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6054   +/-   ##
=======================================
  Coverage   58.99%   58.99%           
=======================================
  Files         358      358           
  Lines       30004    30004           
=======================================
  Hits        17700    17700           
  Misses      11323    11323           
  Partials      981      981           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates multiple internal packages by moving them from a nested cli/internal/ location to a single top-level internal/ package.

  • Updated import paths for jsonstream and oauth/manager (among others) in various CLI commands.
  • Simplified package structure by collapsing redundant internal package hierarchies.

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cli/trust/trust_push.go Updated the jsonstream import to the new top-level internal path.
cli/command/swarm/ca.go Updated the jsonstream import to the new top-level internal path.
cli/command/service/logs.go Updated the logdetails import to the new top-level internal path.
cli/command/service/helpers.go Updated the jsonstream import to the new top-level internal path.
cli/command/registry/logout.go Updated the oauth/manager import to the new top-level internal path.
cli/command/registry/login.go Updated the oauth/manager import to the new top-level internal path.
cli/command/plugin/upgrade.go Updated the jsonstream import to the new top-level internal path.
cli/command/plugin/push.go Updated the jsonstream import to the new top-level internal path.
cli/command/plugin/install.go Updated the jsonstream import to the new top-level internal path.
cli/command/image/trust.go Updated the jsonstream import to the new top-level internal path.
cli/command/image/push.go Updated the jsonstream import to the new top-level internal path.
cli/command/image/load.go Updated the jsonstream import to the new top-level internal path.
cli/command/image/import.go Updated the jsonstream import to the new top-level internal path.
cli/command/image/build.go Updated the jsonstream import to the new top-level internal path.
cli/command/container/create.go Updated the jsonstream import to the new top-level internal path.
Copy link
Collaborator

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thx! I was going back and forth a bit "should we keep separation?" but I think the current decision "which internal one?" was blurry enough to consider; let's just use a single one, until we have a strong reason to split ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code status/2-code-review
3 participants