Skip to content

fix: cz bump subdir #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Conversation

Yusin0903
Copy link
Contributor

@Yusin0903 Yusin0903 commented Apr 16, 2025

Description

This pull request fixes the construction of the changelog file name in changelog.py to ensure type safety and correct path handling. It also adds proper error handling for missing or invalid changelog file names.

Checklist

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

The changelog command should now correctly resolve the changelog file path, regardless of whether the config path is set, and should raise a clear error if the file name is missing or invalid.

Steps to Test This Pull Request

  1. Run poetry all and ensure all checks pass.
  2. Run the changelog command with and without the --file-name argument.
  3. Verify that the changelog file is created at the expected location.
  4. Check that an error is raised if the changelog file name is missing or invalid.

Additional context

Sorry, I don' t know why my last branch have hide word problem. So I open lots of PR and close them .

By the way, I saw the github action warning
This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see https://github.com/actions/runner-images/issues/11101Show more

@Lee-W Lee-W force-pushed the fix-cz-bump-subdir branch from c237525 to 99b4faa Compare May 6, 2025 02:29
@Lee-W
Copy link
Member

Lee-W commented May 6, 2025

Hey, sorry for the late review. I just came back and tried to rebase from the latest main.

@Lee-W Lee-W force-pushed the fix-cz-bump-subdir branch from 99b4faa to 2bc2fa8 Compare May 6, 2025 02:32
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (120d514) to head (2bc2fa8).
Report is 598 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
+ Coverage   97.33%   97.55%   +0.21%     
==========================================
  Files          42       57      +15     
  Lines        2104     2658     +554     
==========================================
+ Hits         2048     2593     +545     
- Misses         56       65       +9     
Flag Coverage Δ
unittests 97.55% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this PR. Thanks @Yusin0903 . But will leave it open for a few days so that others can check as well

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 6, 2025
@Lee-W Lee-W merged commit 7bea5a5 into commitizen-tools:master May 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check
3 participants