-
-
Notifications
You must be signed in to change notification settings - Fork 280
fix: cz bump subdir #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cz bump subdir #1391
Conversation
…ngelog to the right place
Hey, sorry for the late review. I just came back and tried to rebase from the latest main. |
…struction from args and config
…d modify the path linter and test parameter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.21%
==========================================
Files 42 57 +15
Lines 2104 2658 +554
==========================================
+ Hits 2048 2593 +545
- Misses 56 65 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this PR. Thanks @Yusin0903 . But will leave it open for a few days so that others can check as well
Description
This pull request fixes the construction of the changelog file name in changelog.py to ensure type safety and correct path handling. It also adds proper error handling for missing or invalid changelog file names.
Checklist
poetry all
locally to ensure this change passes linter check and testExpected behavior
The changelog command should now correctly resolve the changelog file path, regardless of whether the config path is set, and should raise a clear error if the file name is missing or invalid.
Steps to Test This Pull Request
poetry all
and ensure all checks pass.--file-name
argument.Additional context
Sorry, I don' t know why my last branch have hide word problem. So I open lots of PR and close them .
By the way, I saw the github action warning
This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see https://github.com/actions/runner-images/issues/11101Show more