Allow configuring trusted domains at run-time #7339
Merged
+89
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be set either: 1. In the product.json (normally the product.json is embedded during the build and not read at run-time). 2. With the --link-protection-trusted-domains flag.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7339 +/- ##
==========================================
+ Coverage 73.00% 73.44% +0.43%
==========================================
Files 29 29
Lines 1793 1796 +3
Branches 383 384 +1
==========================================
+ Hits 1309 1319 +10
+ Misses 409 404 -5
+ Partials 75 73 -2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
code-asher
force-pushed
the
asher/trusted-domains
branch
from
a9c8392 to
d754e0f
Compare
bdsoha
reviewed
May 6, 2025
Comment on lines
+718
to
+723
| if (opt === true) { | ||
| return `--${optName}` | ||
| } else if (Array.isArray(opt)) { | ||
| return opt.map((o) => `--${optName}=${o}`) | ||
| } | ||
| return `--${optName}=${opt}` |
There was a problem hiding this comment.
Suggested change
| if (opt === true) { | |
| return `--${optName}` | |
| } else if (Array.isArray(opt)) { | |
| return opt.map((o) => `--${optName}=${o}`) | |
| } | |
| return `--${optName}=${opt}` | |
| if (opt === true) { | |
| return `--${optName}` | |
| } | |
| if (Array.isArray(opt)) { | |
| return opt.map((o) => `--${optName}=${o}`) | |
| } | |
| return `--${optName}=${opt}` |
There was a problem hiding this comment.
Technically equivalent, true, but stylistically I like having one less line 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a long-standing issue with repeatable flags in the config.