how to contribute by cpython unittest #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
reviewed
Apr 3, 2020
_posts/2020-04-04-how-to-contribute-by-cpython-unittest.markdown
Outdated
Show resolved
Hide resolved
coolreader18
approved these changes
Apr 3, 2020
| 1. At least it must be able to start to run the test. Fix the test code or bug until it runs at least a single unit of the test. Typically, unimplemented stdlib or missing files of unittest can make issues. Sometimes RustPython bugs make issues too. | ||
| 2. If any test is not loadable by `SyntaxError`, that part is required to be commented out. | ||
| 3. If any test leads to a crash of RustPython, this code is not possible to run. Mark the test to skip. | ||
| 4. If any test is run but fails, this is an incompatibility issue. Mark the test as an expected failure. |
There was a problem hiding this comment.
Maybe mention the convention we have here of TODO: RUSTPYTHON in skip messages or expectedFailure comments?
palaviv
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.