Update the What's Left modules.csv #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Thank you for contributing. I am taking a closer look :) |
|
Note: One thing I discovered with the whats_left.sh script was that it returns different results based on the operating system you run it on. I originally ran it on MacOS (darwin) but was saw that the |
|
This looks perfect. Thanks again! 🐍 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the What's Left
modules.csvby by running the whats_left.sh script from RustPython:main to updatewhats_left.tempand then running the whats_left_modules.sh script to updatemodules.csv.Note: I was mainly looking to remove
filecmpfrom the list after merging #3526, but I figured I would run the update script instead.I've also added in separate sections for the public vs private modules.