Skip to content

Show notes for skipped tests if they exist and add support for expectedFailure test results #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 29, 2020

Conversation

coolreader18
Copy link
Member

No description provided.

@coolreader18
Copy link
Member Author

@mireille-raad could you review this?

@coolreader18
Copy link
Member Author

I shifted skips to the failure spot in the summary because there is never a failure that gets to the data; if any of the tests fail then they shouldn't be on master and they results data won't get pushed to the repository. Anyway, here's what the summary graph looks like now:
image

@mireille-raad
Copy link
Member

this looks good to me. I was expecting the mobile layout to break, but even that still looks good.

Thanks for adding the expected failures and other comments.

@mireille-raad
Copy link
Member

mireille-raad commented May 29, 2020

Maybe we can do one thing:

remove the "empty" from the filters? before this filtered the empty rows, now these rows have "expected failures".

or

rename "empty" to "summary view" and pull it to the right. this can look like this
Screen Shot 2020-05-29 at 10 23 15 AM

You only need to rename "empty" -> "summary view" and add a class/css with:
margin-left: auto;

then the page looks like this
Screen Shot 2020-05-29 at 10 26 42 AM

@coolreader18 coolreader18 merged commit 166fb48 into master May 29, 2020
@coolreader18 coolreader18 deleted the skip-notes branch June 2, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants