Skip to content

Regrtest summary #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2020
Merged

Regrtest summary #12

merged 5 commits into from
May 27, 2020

Conversation

Ryex
Copy link
Contributor

@Ryex Ryex commented May 27, 2020

Add summaries for tests to quickly see passed | skipped | failed information

Screenshots:
image

This adds an include for a result summary: this include can also do a badge like SVG if svg=true is passed. but defaults to the table block seen above.

it can do both if svg=true and table=true are passed at the same time.

passing just table=true gets you just the table.

image

I slightly modified the template to allow this include to be added to the right of the head for test groups.

@mireille-raad
Copy link
Member

mireille-raad commented May 27, 2020

This is awesome and adds a lot of information to the page :D Also, neat way to add them with partials!

I have some comments on styles/colors, but those are really minor details/up to the maintainer discretion.

I would ditch the "rust"/"orange" color that I originally used as a background for the header and maybe use black instead. black is more neutral and might go better with the green/yellow/red.

The css class is results-test in style.css.... on line 253.

.results-test {
margin-top: 50px;
color: #fff;
font-size: 1.1rem;
background-color: #F74C00;
word-wrap: anywhere;
}

(it is not the best class name now that I think of it ;p )

also for the bar height, maybe 20px instead of 40?

<div class="row" 
    style="background: linear-gradient(to right, 
            green {{ pass_percent }}%, 
              yellow {{ pass_percent }}% {{ skip_percent | plus: pass_percent }}%, 
              red {{ skip_percent | plus: pass_percent }}% {{ fail_percent | plus: pass_percent | plus: skip_percent }}%
            ); 
           height: 40px;">
@Ryex
Copy link
Contributor Author

Ryex commented May 27, 2020

I adjusted the colors a bit to contrast better with the background, also adjusted the bar height to 20px
and fixed the border color for the table

image

@coolreader18
Copy link
Member

Looks great!

@coolreader18 coolreader18 merged commit 736a676 into RustPython:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants