Skip to content

PostgresNode and ConnectionParams #244

Closed
@dmitry-lipetsk

Description

@dmitry-lipetsk

Hello All,

I offer to do not use ConnectionParams object in PostgresNode.

PostgresNode must use os_ops instead.

What does it mean?

It means that if you want to use PostgresNode with RemoteOperations object, you have to explicitly create RemoteOperations object and use it to create PostgresNode object.

It allows us to create more clear/exact/simple code. Now we can to create PostgresNode to work with remote host by two ways - through conn_params and through using of prepared os_ops object. New code will allow only one way - through os_ops.

To backward compatibility we can save conn_params parameter in PostgresNode constructor with None default value and verification that it is None. In the future conn_params will be removed at all.

Also, if we want to pass port_manager to PostgresNode constructor, we have to pass valid os_ops parameter, too. This will be checked in new code.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions