Skip to content

DEPR: Index.reindex with duplicate index #42568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 8, 2021
Merged

DEPR: Index.reindex with duplicate index #42568

merged 10 commits into from
Aug 8, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Discussed on this week's call.
@jbrockmendel jbrockmendel added the Deprecate Functionality to remove in pandas label Jul 23, 2021
@jreback jreback added this to the 1.4 milestone Aug 5, 2021
@jreback jreback added the Index Related to the Index class or subclasses label Aug 5, 2021
jreback
jreback reviewed Aug 5, 2021
View reviewed changes
pandas/core/indexes/base.py Outdated
@@ -3888,6 +3888,15 @@ def reindex(
if self.equals(target):
indexer = None
else:
if not self.is_unique:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to do this on L3912? e.g. raise if those conditions are tru first. also don't we know that its unique at this point?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to do this on L3912? e.g. raise if those conditions are tru first

sure, will move this down

also don't we know that its unique at this point?

nope
jreback
jreback requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment
@jreback jreback mentioned this pull request Aug 5, 2021
Closed
@jreback jreback merged commit 8fb347f into pandas-dev:master Aug 8, 2021
@jbrockmendel jbrockmendel deleted the ref-reindex-ci branch August 9, 2021 01:50
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@jbrockmendel @feefladder
DEPR: Index.reindex with duplicate index (pandas-dev#42568)
35f320d
@jerichomcleod jerichomcleod mentioned this pull request Nov 9, 2022
Closed
@mroeschke mroeschke mentioned this pull request Apr 28, 2023
Closed
@PabloRuizCuevas PabloRuizCuevas mentioned this pull request Aug 4, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
2 participants
@jbrockmendel @jreback